| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Reduce the number of special cases to build contrib modules on windows |
| Date: | 2021-07-28 00:07:15 |
| Message-ID: | CAApHDvpUj4ip=U69M2NyvcLYn_Hq_u6SEhOWD0mDBhU2sCn9hA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 28 Jul 2021 at 02:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > 0001: Removes an include directory for dblink. This appears like it's
> > not needed. It was added in ee3b4188a (Jan 2010), but an earlier
> > commit, 320c7eb8c (June 2008) seems to have made it pointless. It's
> > still a mystery to me why ee3b4188a would have been required in the
> > first place.
>
> FWIW, I poked around in the mailing list archives around that date
> and couldn't find any supporting discussion. It does seem like it
> shouldn't be needed, given that dblink's Makefile does no such thing.
I think the reason is that src/backend/utils/Makefile symlinks
fmgroids.h into src/include/utils. The copy you added in 320c7eb8c
seems to be the MSVC build's equivalent of that.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-07-28 01:04:58 | Re: archive status ".ready" files may be created too early |
| Previous Message | Peter Smith | 2021-07-27 23:39:02 | Replace l337sp34k in comments. |