Re: A structure has changed but comment modifications maybe missed

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: 甄明洋 <zhenmingyang(at)yeah(dot)net>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: A structure has changed but comment modifications maybe missed
Date: 2023-03-30 01:55:53
Message-ID: CAApHDvpS1veLtizEvUiQyhcP-uR7=7gnaDn1kPW3pPbeX95X1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, 27 Mar 2023 at 15:20, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> A further search shows several other places referring to TTS_SHOULDFREE,
> which I think should be TTS_FLAG_SHOULDFREE.
>
> tuptable.h:71
> tuptable.h:82
> execTuples.c:388
> execTuples.c:557

I think the attached is what you have in mind. Can you confirm?

David

Attachment Content-Type Size
fix_outdated_comments_regarding_tupletableslots.patch application/octet-stream 3.0 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2023-03-30 02:02:09 Re: A structure has changed but comment modifications maybe missed
Previous Message Tom Lane 2023-03-29 22:21:38 Re: BUG #16329: Valgrind detects an invalid read when building a gist index with buffering