| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |
| Date: | 2024-05-07 05:00:17 |
| Message-ID: | CAApHDvpKZYKpkFFzV-6FfqHd4TjufzeEGZh_04U9mCM_2E9WHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 7 May 2024 at 16:47, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> --- a/src/backend/optimizer/plan/initsplan.c
> +++ b/src/backend/optimizer/plan/initsplan.c
> @@ -1888,7 +1888,7 @@ deconstruct_distribute_oj_quals(PlannerInfo *root,
> qualscope = bms_union(sjinfo->syn_lefthand, sjinfo->syn_righthand);
> qualscope = bms_add_member(qualscope, sjinfo->ojrelid);
> ojscope = bms_union(sjinfo->min_lefthand, sjinfo->min_righthand);
> - nonnullable_rels = sjinfo->syn_lefthand;
> + nonnullable_rels = bms_copy(sjinfo->syn_lefthand);
I was busy looking at this too and I came to the same conclusion.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-05-07 05:01:44 | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |
| Previous Message | Richard Guo | 2024-05-07 04:47:02 | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |