| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: shadow variables - pg15 edition |
| Date: | 2022-10-06 00:00:41 |
| Message-ID: | CAApHDvpFy3Bve8q+gKTFygGd+vr4oUb7mf2ogDhju_bp=7r88g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 6 Oct 2022 at 11:50, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Thu, 6 Oct 2022 at 10:40, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Your commit message said the last shadowed variable. But building with
> > -Wshadow=compatible-local triggers a bunch of warnings for me (see trimmed at
> > the end). Looks like it "only" fixed it for src/, without optional
> > dependencies like gssapi and python.
>
> Well, that's embarrassing. You're right. I only fixed the ones I saw
> from running make in the base directory of the tree. I'll set about
> fixing these nownow.
Here's a patch which (I think) fixes the ones I missed.
David
| Attachment | Content-Type | Size |
|---|---|---|
| final_shadow_cleanup.patch | text/plain | 8.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-10-06 00:31:11 | Re: Add meson.build to version_stamp.pl |
| Previous Message | Andres Freund | 2022-10-05 23:20:38 | Re: Move backup-related code to xlogbackup.c/.h |