| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Implement pg_wal_replay_wait() stored procedure |
| Date: | 2024-04-02 23:24:17 |
| Message-ID: | CAApHDvpE3p3iiLy-H3jzBHmGn1V+KeeH=myO7+359qLjRF=Nzg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, 3 Apr 2024 at 09:42, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> I'm trying to figure out if this failure could be related to this commit...
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=culicidae&dt=2024-04-02%2020%3A24%3A55
Yeah, I think it is.
The problem is that in WaitLSNSetLatches() waitLSN is NULL, so
SpinLockAcquire(&waitLSN->mutex); segfaults. This shared memory
segment is initialized in WaitLSNShmemInit() called via
CreateSharedMemoryAndSemaphores(). If you look at main() in main.c
EXEC_BACKEND builds call SubPostmasterMain(), which has no call to
CreateSharedMemoryAndSemaphores(), so waitLSN isn't initialized.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-04-02 23:56:31 | pgsql: Move WaitLSNShmemInit() to CreateOrAttachShmemStructs() |
| Previous Message | Thomas Munro | 2024-04-02 23:23:50 | Re: pgsql: Implement pg_wal_replay_wait() stored procedure |