| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | James Coleman <jtc331(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Geoghegan <pg(at)bowt(dot)ie>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays |
| Date: | 2021-05-08 02:04:24 |
| Message-ID: | CAApHDvpDmVDfBN-fN+rgUbiSQqWzO5a_jTU_zKw_SCQjZ1oafA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 8 May 2021 at 13:37, James Coleman <jtc331(at)gmail(dot)com> wrote:
>
> On Fri, May 7, 2021 at 9:16 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I don't immediately see why you can't add an "invert" boolean flag to
> > ScalarArrayOpExpr and let the executor machinery deal with this. That'd
> > have the advantage of not having to depend on there being a negator.
>
> Don't we need to have a negator to be able to look up the proper has
> function? At least somewhere in the process you'd have to convert from
> looking up the <> op to looking up the = op and then setting the
> "invert" flag.
Yeah, we *do* need to ensure there's a negator in the planner as we
need to use it during hash probes. It's no good checking the hash
bucket we landed on does match with the <> operator's function. We
won't find many matches that way!
I'm not opposed to adding some new field if that's what it takes. I'd
imagine the new field will be something like negfuncid which will be
InvalidOid unless the hash function is set and useOr == false
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-05-08 02:08:39 | Re: Anti-critical-section assertion failure in mcxt.c reached by walsender |
| Previous Message | James Coleman | 2021-05-08 01:49:50 | Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays |