| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | 李杰(慎追) <adger(dot)lj(at)alibaba-inc(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: A problem in ExecModifyTable |
| Date: | 2021-08-17 11:54:51 |
| Message-ID: | CAApHDvp8yh9etjk0i6-oVEm=rfJ7k_9+eJEFg-8dFmyg7bEASg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 17 Aug 2021 at 19:06, 李杰(慎追) <adger(dot)lj(at)alibaba-inc(dot)com> wrote:
> Your answer explains that we still need to ModifyTable node without Leaf partitions.
> You are right about this.
>
> But you can review the source code again,
I'd been looking at the code in ExecInitModifyTable() that's the same
as what you pasted thinking you meant that. I think for the check for
partitioned tables in ExecModifyTable() then it's likely just dead
code. It seems to be causing a bit of confusion though, so might be
worth doing something about. Copied in Tom to see what he thinks as
it's one of his.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ekaterina Sokolova | 2021-08-17 12:30:10 | Re: [PATCH] Add extra statistics to explain for Nested Loop |
| Previous Message | Justin Pryzby | 2021-08-17 11:30:18 | Re: Autovacuum on partitioned table (autoanalyze) |