From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Use generation memory context for tuplestore.c |
Date: | 2024-07-06 02:05:46 |
Message-ID: | CAApHDvp4xi-YBPBcXnLO5fX1LmDnneh_0C8mdgojhFn4f-cVWg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, 6 Jul 2024 at 12:08, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> The attached fixes the issue. I'll stare at it a bit more and try to
> decide if that's the best way to fix it.
I did that staring work and thought about arranging the code to reduce
the number of #ifdefs. In the end, I decided it was better to keep the
two "if" checks close together so that it's easy to see that one does
> and the other >=. Someone else's tastes may vary.
I adjusted the comment to remove the >= mention and pushed the
resulting patch and backpatched to 16, where I broke this in
0e480385e.
Thanks for the report.
David
David
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2024-07-06 02:06:48 | Re: Wrong results with grouping sets |
Previous Message | Richard Guo | 2024-07-06 01:26:49 | Re: Wrong results with grouping sets |