| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Christensen <david(dot)christensen(at)crunchydata(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] expand the units that pg_size_pretty supports on output |
| Date: | 2021-07-08 04:29:58 |
| Message-ID: | CAApHDvp4KLg7xmg_nXLD6EPkOFrGNQDGfLQQBFVUBveSQXENyA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 8 Jul 2021 at 13:31, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> It feels like if we're going to fix this negative rounding thing then
> we should maybe do it and backpatch a fix then rebase this work on top
> of that.
Here's a patch which I believe makes pg_size_pretty() and
pg_size_pretty_numeric() match in regards to negative values.
Maybe this plus your regression test would be ok to back-patch?
David
| Attachment | Content-Type | Size |
|---|---|---|
| adjust_pg_size_pretty_rounding_for_negative_values.patch | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuro Yamada | 2021-07-08 04:46:41 | Re: list of extended statistics on psql (\dX) |
| Previous Message | Justin Pryzby | 2021-07-08 04:28:06 | Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers. |