From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | craig(dot)ringer(at)enterprisedb(dot)com, matthieu(dot)garrigues(at)gmail(dot)com, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Implement pipeline mode in libpq |
Date: | 2021-04-06 21:53:30 |
Message-ID: | CAApHDvp1w-OFJ7bv7LVjEcWR0N+=TgffijgA96WxrYH1v85kJg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Wed, 7 Apr 2021 at 01:53, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> I did not intend to have the define defined at all times. Leaving it
> there was an oversight. Let's just remove the #define line; users
> interested in that output can turn it on when they need it. Removing it
> means less clutter in the buildfarm output. Interesting conditions that
> the test should check for should be tested and dealt with by using
> pg_fatal, so that the test framework correctly detects a failure. The
> pg_debug lines are there just to debug the test itself.
>
> Now about the define being called DEBUG, that was just a silly
> oversight; your suggestion to change it to DEBUG_OUTPUT is good, so
> let's do that.
>
> I +1 you pushing your patch.
Thanks for having a look at this.
I've just pushed a small fix to do the rename and remove the #define.
David
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-04-06 22:13:29 | pgsql: Postpone some more stuff out of ExecInitModifyTable. |
Previous Message | David Rowley | 2021-04-06 21:51:54 | pgsql: Fix compiler warning for MSVC in libpq_pipeline.c |