Re: BUG #18755: Using Natts_pg_trigger rather than Natts_pg_event_trigger for event trigger

On Sun, 29 Dec 2024 at 22:37, 张鑫 <zhanghien(at)qq(dot)com> wrote:
> Here is the fix for BUG #18755. I fail to upload the patch with my mailbox and I just paste the text here because it's simple enough.

I've not seen this bug report. Perhaps it's caught up in moderation?

> --- a/src/backend/commands/event_trigger.c
> +++ b/src/backend/commands/event_trigger.c
> @@ -276,8 +276,8 @@ insert_event_trigger_tuple(const char *trigname, const char *eventname, Oid evtO
> Relation tgrel;
> Oid trigoid;
> HeapTuple tuple;
> - Datum values[Natts_pg_trigger];
> - bool nulls[Natts_pg_trigger];
> + Datum values[Natts_pg_event_trigger];
> + bool nulls[Natts_pg_event_trigger];
> NameData evtnamedata,
> evteventdata;
> ObjectAddress myself,

Yes, that's better. However, no particular harm done since pg_trigger
has more columns than pg_event_trigger. For that reason, it's
probably fine to fix in master only. The number of columns in those
tables in the back branches isn't going to change.

I scanned around to see if there's been any similar copy/paste errors,
but couldn't see any.

I'll take care of pushing this. Thanks for the patch.

David