Incorrect EXPLAIN ANALYZE output in bloom index docs

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Incorrect EXPLAIN ANALYZE output in bloom index docs
Date: 2024-12-09 07:53:14
Message-ID: CAApHDvovx8kQ0=HTt85gFDAwmTJHpCgiSvRmQZ_6u_g-vQYM_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I was fixing up the patch in [1] with the intention of committing it
when I noticed that there are a few outdated EXPLAIN ANALYZE examples
in the documents for the bloom contrib module.

The example outputs look like they've been created with a 100 thousand
row table, but the commands given are to insert 10 million rows into
that table. I suspect someone did a 100x on the example row count at
some point during development and forgot to update the EXPLAIN output.

The patch I want to commit adds buffer outputs to these EXPLAINs, so I
kinda need to fix these before adding that, otherwise what I want to
add does not make any sense.

Patch attached. I propose to backpatch this fix.

David

Attachment Content-Type Size
v1-0001-Doc-fix-incorrect-EXPLAIN-ANALYZE-output-for-bloo.patch application/octet-stream 4.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-12-09 08:03:54 Re: shared-memory based stats collector - v70
Previous Message Kirill Reshke 2024-12-09 07:50:20 Re: Pass ParseState as down to utility functions.