Re: SupportRequestRows support function for generate_series_timestamptz

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: SupportRequestRows support function for generate_series_timestamptz
Date: 2024-07-08 01:28:10
Message-ID: CAApHDvois4b9Mf7+wHffQC+7XzoV9QVF6g5-WxVkYzHYivPR1g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 14 Apr 2024 at 15:14, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I had some spare time today, so wrote a patch, which gives you:
>
> postgres=# explain analyze select * from generate_series('2024-01-01',
> '2025-01-01', interval '1 day');
> QUERY PLAN
> ------------------------------------------------------------------------------------------------------------------
> Function Scan on generate_series (cost=0.00..3.67 rows=367 width=8)
> (actual time=0.258..0.291 rows=367 loops=1)

Here's v2 of the patch with some added regression tests.

I did this by writing a plpgsql function named explain_mask_costs()
which has various boolean parameters to mask out the various portions
of the costs. I wondered if this function should live somewhere else
as it seems applicable to more than just misc_functions.sql. Maybe
test_setup.sql. I'll leave where it is for now unless anyone thinks
differently.

This is a fairly simple and seemingly non-controversial patch. I plan
to push it in the next few days unless there's some feedback before
then.

David

Attachment Content-Type Size
v2-0001-Add-support-function-for-generate_series-for-time.patch application/octet-stream 13.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-07-08 02:13:44 Re: pg_maintain and USAGE privilege on schema
Previous Message Michael Paquier 2024-07-08 00:58:10 Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows