Re: pgsql: Expose internal function for converting int64 to numeric

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Expose internal function for converting int64 to numeric
Date: 2020-09-15 00:35:57
Message-ID: CAApHDvofA_vsrpC13mq_hZyuye5B-ssKEaer04OouXYCO5-uXQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, 10 Sep 2020 at 06:41, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> src/backend/utils/adt/dbsize.c | 21 ++----

This change introduced a new compiler warning on MSVC.

src\backend\utils\adt\dbsize.c(630): warning C4334: '<<': result of
32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)

I see all of the calls all bit shift by a constant that''s always
below 32. So there's no actual danger here, but the attached at least
silences the warning.

I'll push it in a bit if nobody has other ideas.

David

Attachment Content-Type Size
fix_compiler_warning.patch application/octet-stream 551 bytes

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2020-09-15 03:09:17 pgsql: Fix compiler warning
Previous Message Tom Lane 2020-09-14 20:09:06 pgsql: Stamp 13rc1.