| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Richard Guo <guofenglinux(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |
| Date: | 2024-05-07 22:37:26 |
| Message-ID: | CAApHDvodWJivj6diG72g+Jos1gxirxqCqR7UgsDM2cNBbS+wqw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 8 May 2024 at 10:35, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Wed, 8 May 2024 at 06:20, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I find that Richard's proposed fix makes the core regression tests
> > pass, but we still fail check-world. So I'm afraid we need something
> > more aggressive, like the attached which makes make_restrictinfo
> > copy all its input bitmapsets. Without that, we still have sharing
> > of bitmapsets across different RestrictInfos, which seems pretty
> > scary given what we now see about the effects of 00b41463c. This
> > seems annoyingly expensive, but maybe there's little choice?
>
> We could make the policy copy-on-modify. If you put bms_copy around
> the bms_del_member() calls in remove_rel_from_query(), does it pass
> then?
err, I mean bms_copy() the set before passing to bms_del_member().
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-05-07 22:40:16 | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |
| Previous Message | David Rowley | 2024-05-07 22:35:42 | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |