On Thu, 10 Oct 2024 at 08:38, James Hunter <james(dot)hunter(dot)pg(at)gmail(dot)com> wrote:
> We had two almost-identical copies of the utility function
> clause_sides_match_join() -- one in joinpath.c, and one in
> analyzejoins.c. Both copies were marked "inline," so we might as well
> just move the (inline) function definition into a common header file.
> I chose pathnode.h, because it is already #included by both of the .c
> files.
I'm in favour of the deduplication. pathnode.h seems like a strange
choice. restrictinfo.h seems more suited.
(I really wonder how much the inlining is giving us given that the
function itself calls other non-inlineable functions)
David