Re: [PATCH] expand the units that pg_size_pretty supports on output

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
Cc: Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] expand the units that pg_size_pretty supports on output
Date: 2021-07-07 04:37:43
Message-ID: CAApHDvoaoAqjE3usLG-aSe9MJeeM1c4WQvaR3HbeGbCqYbMa7Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 7 Jul 2021 at 02:46, David Christensen
<david(dot)christensen(at)crunchydata(dot)com> wrote:
> if we do decide to expand the units table there will be a
> few additional changes (most significantly, the return value of `pg_size_bytes()` will need to switch
> to `numeric`).

I wonder if it's worth changing pg_size_bytes() to return NUMERIC
regardless of if we add any additional units or not.

Would you like to create 2 patches, one to change the return type and
another to add the new units, both based on top of the v2 patch I sent
earlier?

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-07-07 04:41:13 Re: ExecRTCheckPerms() and many prunable partitions
Previous Message David Rowley 2021-07-07 04:32:19 Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays