| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Improve PQtrace() output format |
| Date: | 2021-04-06 04:38:04 |
| Message-ID: | CAApHDvoRG25X_=ZCGSPb4KN_j2iu=G2uXsRSg8NBZeuhkOSETg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, 31 Mar 2021 at 12:17, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> Improve PQtrace() output format
I see the Visual Studio buildfarm members have been getting a compiler
warning since this commit [1]
(ClCompile target) ->
src/interfaces/libpq/fe-trace.c(87): warning C4133: 'function':
incompatible types - from 'long *' to 'const time_t *const '
[C:\\pgbuildfarm\\pgbuildroot\\HEAD\\pgsql.build\\libpq.vcxproj]
It looks like this is due to long being 32-bits on Visual Studio.
We could just assign tval.tv_sec to a local time_t value to get rid of
it. See attached.
David
| Attachment | Content-Type | Size |
|---|---|---|
| fix_fe-trace_compiler_warning.patch | application/octet-stream | 615 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2021-04-06 04:45:01 | pgsql: Add function to log the memory contexts of specified backend pro |
| Previous Message | Michael Paquier | 2021-04-06 04:31:06 | pgsql: Fix some issues with SSL and Kerberos tests |