Re: Is select_outer_pathkeys_for_merge() too strict now we have Incremental Sorts?

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Is select_outer_pathkeys_for_merge() too strict now we have Incremental Sorts?
Date: 2022-08-01 23:04:58
Message-ID: CAApHDvoEHWccFO73O-t6Htpa=UKzwVKTWNxPozb8dOzuLU93PA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 21 Jul 2022 at 14:23, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> On Thu, Jul 21, 2022 at 3:47 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> Maybe your idea could be made to work in cases where
>> bms_equal(joinrel->relids, root->all_baserels). In that case, we
>> should not be processing any further joins and don't need to consider
>> that as a factor for the scoring.
>
>
> That should work, as long as this case is common enough to worth we
> writing the codes.

Thanks for looking at this patch. I've now pushed it.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2022-08-01 23:08:35 Re: [Commitfest 2022-07] is Done!
Previous Message Jacob Champion 2022-08-01 23:03:11 Re: [Commitfest 2022-07] is Done!