Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option
Date: 2023-04-11 01:59:36
Message-ID: CAApHDvoDqCko=wRx6hJ6DsNAGA10+qWYDtZJLG4HdKWACPv=ow@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, 11 Apr 2023 at 13:23, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> This commit added the following error message.
>
> > errmsg("value: \"%s\": is invalid for buffer_usage_limit",
>
> It looks as the follows on terminal.
>
> postgres=# vacuum (buffer_usage_limit 'x');
> ERROR: value: "x": is invalid for buffer_usage_limit
>
> I'm not sure why the message has two colons. [1] talks about the
> message but doesn't really explain the reason for this.

Probably we can use what a GUC like work_mem does for this case:

postgres=# set work_mem = 'x';
ERROR: invalid value for parameter "work_mem": "x"

with the attached, what you tried becomes:

postgres=# vacuum (buffer_usage_limit 'x');
ERROR: invalid value for "buffer_usage_limit": "x"

How's that?

David

Attachment Content-Type Size
adjust_buffer_usage_limit_error.patch application/octet-stream 1.2 KB

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2023-04-11 03:02:38 Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option
Previous Message Kyotaro Horiguchi 2023-04-11 01:23:35 Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option