| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Increase value of OUTER_VAR |
| Date: | 2021-07-04 13:51:42 |
| Message-ID: | CAApHDvo4PO+4SosbVSH6XwFwrRZxMfMEB9G7kczOMSJpL0UJJg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 3 Jul 2021 at 06:23, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> So I'm inclined to propose pushing this and seeing what happens.
Is this really sane?
As much as I would like to see the 65k limit removed, I just have
reservations about fixing it in this way. Even if we get all the
cases fixed in core, there's likely a whole bunch of extensions
that'll have bugs as a result of this for many years to come.
"git grep \sIndex\s -- *.[ch] | wc -l" is showing me 77 matches in the
Citus code. That's not the only extension that uses the planner hook.
I'm really just not sure it's worth all the dev hours fixing the
fallout. To me, it seems much safer to jump bump 65k up to 1m. It'll
be a while before anyone complains about that.
It's also not that great to see the number of locations that you
needed to add run-time checks for negative varnos. That's not going to
come for free.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-07-04 14:54:50 | Re: Reducing the cycle time for CLOBBER_CACHE_ALWAYS buildfarm members |
| Previous Message | David Rowley | 2021-07-04 13:01:04 | Re: ATTACH PARTITION locking documentation for DEFAULT partitions |