| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17855: Uninitialised memory used when the name type value processed in binary mode of Memoize |
| Date: | 2023-03-23 04:56:50 |
| Message-ID: | CAApHDvo2xvOqv=tiQx4DXm1yHG_HUsTz0Uzuu60kzuQQx+D90A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, 23 Mar 2023 at 17:01, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> Seems it there are a few hacks that try to make this work. I wonder
> if we should just invent new hacks in the form of a new version of
> datum_image_eq that accepts a pointer to a FormData_pg_attribute
> instead of typByVal and typLen then just special case NAMEOID types to
> always compare as cstrings. Same for datum_image_hash().
Here are patches to implement versions of datum_image_eq() and
datum_image_hash() which accept FormData_pg_attribute pointers instead
of the byval and len parameters.
The 0002 patch just removes the now unused functions.
David
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Work-around-name-cstring-problem-in-datum_image_e.patch | application/octet-stream | 10.8 KB |
| v1-0002-Remove-unused-datum_image_eq-and-datum_image_hash.patch | application/octet-stream | 5.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sandeep Thakkar | 2023-03-23 05:52:48 | Re: BUG #17857: Uninstaller does not work |
| Previous Message | Tianyi Gao | 2023-03-23 04:38:10 | Re: operator class "xxx" does not exist for access method "yyy" |