From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: wrong comments in ClassifyUtilityCommandAsReadOnly |
Date: | 2024-12-23 06:56:35 |
Message-ID: | CAApHDvo1-zFDXq8HYt1a+3jiH3D+YYqxh6dv+do65n_6Ad9nmQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 23 Dec 2024 at 18:53, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > Another reason I deleted that is that
> > since the file contains helper functions, I didn't want to write a new
> > comment based on what functions are there now as it may put someone
> > else off from adding new ones if the new one doesn't fit the comment.
>
> Perhaps we could define it as "Support routines for dealing with
> DefElem nodes". You're right that maybe someone would want to
> throw in something else, but would it really belong? The file's
> charter seems far narrower now than it once was.
I felt that it was better to leave the scope a bit wider than that,
but I don't feel very strongly, so I've pushed it with your wording
suggestion.
Thanks
David
From | Date | Subject | |
---|---|---|---|
Next Message | Corey Huinker | 2024-12-23 07:15:01 | Re: Additional comments around need_escapes in pg_parse_json() |
Previous Message | Michael Paquier | 2024-12-23 06:51:39 | Re: Fix a wrong comment in load_file() |