| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Expand AclMode to 64 bits |
| Date: | 2022-11-24 21:50:44 |
| Message-ID: | CAApHDvo=pn01Y_3zASZZqn+cotF1c4QFCwWgk6MiF0VscaE5ug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, 24 Nov 2022 at 08:44, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Expand AclMode to 64 bits
I noticed this causes a few new warnings on MSVC:
acl.c(629): warning C4334: '<<': result of 32-bit shift implicitly
converted to 64 bits (was 64-bit shift intended?)
acl.c(631): warning C4334: '<<': result of 32-bit shift implicitly
converted to 64 bits (was 64-bit shift intended?)
acl.c(1789): warning C4334: '<<': result of 32-bit shift implicitly
converted to 64 bits (was 64-bit shift intended?)
The attached fixes. I'll push this shortly.
David
| Attachment | Content-Type | Size |
|---|---|---|
| fix_32-bit_shift_warning_on_msvc.patch | text/plain | 743 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-11-24 22:05:52 | pgsql: Fix some 32-bit shift warnings in MSVC |
| Previous Message | David Rowley | 2022-11-24 21:11:11 | pgsql: Improve indenting in _hash_pgaddtup |