| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
| Cc: | Zhang Mingli <zmlpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com> |
| Subject: | Re: Remove useless GROUP BY columns considering unique index |
| Date: | 2024-11-29 07:28:59 |
| Message-ID: | CAApHDvo=+emQvjvRKzbDHY3L7Mm_dKZU7qmy=6cpCtWU+jYs=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 29 Nov 2024 at 19:36, Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
> 1. Thread reference in the patch comment doesn't work.
> 2. May it be possible to move remove_useless_groupby_columns in the
> second commit? It would be easier to review the differences.
For #1, I rewrote the commit message.
I've split into two patches for ease of review. See attached.
David
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Move-remove_useless_groupby_columns-to-initsplan.patch | application/octet-stream | 13.9 KB |
| v10-0002-Remove-redundant-GROUP-BY-columns-using-UNIQUE-i.patch | application/octet-stream | 13.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-11-29 07:54:02 | Re: POC, WIP: OR-clause support for indexes |
| Previous Message | Nazir Bilal Yavuz | 2024-11-29 07:28:20 | Re: Use streaming read API in pgstattuple. |