| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Masahiro(dot)Ikeda(at)nttdata(dot)com |
| Cc: | lena(dot)ribackina(at)yandex(dot)ru, donghanglin(at)gmail(dot)com, geidav(dot)pg(at)gmail(dot)com, melanieplageman(at)gmail(dot)com, tomas(dot)vondra(at)enterprisedb(dot)com, dilipbalaut(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, hlinnaka(at)iki(dot)fi |
| Subject: | Re: Parallel Bitmap Heap Scan reports per-worker stats in EXPLAIN ANALYZE |
| Date: | 2024-07-08 02:47:33 |
| Message-ID: | CAApHDvo+mqzBNW3YX2EnK0P+Y=f=+2VpWXdHF477susd-bk+-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 8 Jul 2024 at 12:19, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> Notice the "Heap Blocks: exact=2250000000" is missing on Windows.
> This is because it wrapped around to a negative value and
> show_tidbitmap_info() only shows > 0 values.
>
> I feel this is a good enough justification to increase the width of
> those counters to uint64, so I'll do that too.
I pushed the widening of the types first as I saw some code in the
EXPLAIN patch which assumed var == 0 is the negator of var > 0. I
couldn't bring myself to commit that knowing it was wrong and also
couldn't bring myself to write <= 0 knowing I was about to make that
look like a weird thing to write for an unsigned type.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-07-08 02:50:02 | Re: SupportRequestRows support function for generate_series_timestamptz |
| Previous Message | Richard Guo | 2024-07-08 02:36:44 | Re: report a typo in comments of ComputeXidHorizonsResult |