| From: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Buffer usage detailed by RelKind in EXPLAIN ANALYZE BUFFERS |
| Date: | 2023-02-14 02:14:58 |
| Message-ID: | CAAhFRxjgZa=PFieotTABHynKpg5OOM+g8r1SPpv25HidrHTFGA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 13, 2023 at 4:39 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> The problem I'm talking about is the increased overhead in InstrStopNode(),
> due to BufferUsageAccumDiff() getting more expensive.
>
Thanks, now I understand the problem better. According to godbolt.com
my patch doubles the number of instructions in this function. Unless
we compute only tables\indexes\matviews.
Anyway, without regarding functionality of this particular patch,
BufferUsageAccumDiff() does not seem slow to me. It's just a
branchless bunch of simd instructions. Performance of this function
might matter only when called gazillion times per second.
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| for godbolt.cpp | application/octet-stream | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-02-14 02:27:25 | Re: Time delayed LR (WAS Re: logical replication restrictions) |
| Previous Message | Andy Fan | 2023-02-14 02:11:23 | Re: A new strategy for pull-up correlated ANY_SUBLINK |