| From: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
|---|---|
| To: | Jelte Fennema <postgres(at)jeltef(dot)nl> |
| Cc: | Greg S <stark(dot)cfm(at)gmail(dot)com>, Jacob Champion <jchampion(at)timescale(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, Michael Banck <mbanck(at)gmx(dot)net>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: [EXTERNAL] Re: Support load balancing in libpq |
| Date: | 2023-03-03 04:52:49 |
| Message-ID: | CAAhFRxjKzhBRsa=PDnRn2-_6j1PwSXKRAGrmmkp613sim7pTDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 1, 2023 at 12:03 PM Jelte Fennema <postgres(at)jeltef(dot)nl> wrote:
>
> done and updated cf entry
>
Hi Jelte!
I've looked into the patch. Although so many improvements can be
suggested, It definitely makes sense as-is too.
These improvements might be, for example, sorting hosts according to
ping latency or something like that. Or, perhaps, some other balancing
policies. Anyway, randomizing is a good start too.
I want to note that the Fisher-Yates algorithm is implemented in a
difficult to understand manner.
+if (j < i) /* avoid fetching undefined data if j=i */
This stuff does not make sense in case of shuffling arrays inplace. It
is important only for making a new copy of an array and only in
languages that cannot access uninitialized values. I'd suggest just
removing this line (in both cases).
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-03-03 05:10:44 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Previous Message | Isaac Morland | 2023-03-03 04:49:16 | Re: Remove source code display from \df+? |