| From: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | sfrost(at)snowman(dot)net, peter(dot)eisentraut(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql \watch 2nd argument: iteration count |
| Date: | 2023-02-27 04:55:45 |
| Message-ID: | CAAhFRxiVgm7jzcmMAekMqr61QBEfh=QtTTi=fDis3Ji0oetFug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for looking into this!
On Mon, Feb 20, 2023 at 6:15 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> FWIW the patch still accepts an incorrect parameter '1abc'
> by ignoring any trailing garbage.
Indeed, fixed.
>
> In any case, I reckon the error message should be more specific. In
> other words, it would be better if it suggests the expected input
> format and range.
+1.
Not a range, actually, because upper limits have no sense for a user.
>
> Regarding the second patch, if we want \watch to throw an error
> message for the garbage trailing to sleep times, I think we should do
> the same for iteration counts.
+1, done.
> Additionally, we need to update the
> documentation.
Done.
Thanks for the review!
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Add-iteration-count-argument-to-psql-watch-comman.patch | application/octet-stream | 6.6 KB |
| v3-0001-Fix-incorrect-argument-handling-in-psql-watch.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-02-27 05:27:08 | Re: [PATCH] fix msvc build libpq error LNK2019 when link openssl; |
| Previous Message | Justin Pryzby | 2023-02-27 04:49:10 | Re: Add LZ4 compression in pg_dump |