Re: pgAgent 4.0 patch

Hello Fahar,

File, pgagent-4.0.0-1-linux-x64.run is uploaded @
https://uploads.enterprisedb.com/download.php?file=bd89aec08d73ceae21cf560c391598f6

On Tue, Jun 5, 2018 at 3:10 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, committed with those changes.
>
> Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS
> Bitrock installers) from git head for Fahar to test?
>
> Once he's happy with them, I'll tag and build the community packages.
>
> Thanks!
>
> On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> On Mon, Jun 4, 2018 at 10:04 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> Can you review the attached please Ashesh?
>>>
>> Hi Dave,
>>
>> Due to the wrong pattern in '.gitignore', it was ignoring the new file
>> 'sql/pgagent--3.4--4.0.sql'.
>> We should ignore only the '*.sql' in the root directory.
>> Something like this.
>>
>> *$ git diff .gitignore*
>> *diff --git a/.gitignore b/.gitignore*
>> *index 9883354..40fe7a9 100644*
>> *--- a/.gitignore*
>> *+++ b/.gitignore*
>> *@@ -6,7 +6,12 @@ CPackSourceConfig.cmake*
>> * Makefile*
>> * cmake_install.cmake*
>> * install_manifest.txt*
>> *-pgagent*
>> *+# Ignore 'pgagent' & 'pgagent.control' in root directory only.*
>> *+/pgagent*
>> *+!/*/pgagent*
>> * pgagent.control*
>> *+!/*/pgagent.control*
>> * *.log*
>> *-*.sql*
>> *+# Ignore '*.sql' files in root directory only.*
>> *+/*.sql*
>> *+!/*/*.sql*
>>
>>
>> And, I am getting the following warning applying the patch.
>>
>> *$ git apply ~/Downloads/pgagent-4.0-update.diff*
>> */Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing
>> whitespace.*
>> *//*
>> *warning: 1 line adds whitespace errors.*
>>
>>
>> Otherwise - it looks good to me.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi
>> <http://www.linkedin.com/in/asheshvashi>*
>>
>>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--

Thanks & Regards

*Paresh More*

[image: NEW-EDB-logo-4c]

Pune, India.
Cell : +919922000564 | www.enterprisedb.com