Re: PATCH: pgAdmin4 windows installer

From: Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>, Hamid Quddus <hamid(dot)quddus(at)enterprisedb(dot)com>
Subject: Re: PATCH: pgAdmin4 windows installer
Date: 2016-06-06 17:15:29
Message-ID: CAAgiCNEOAZJKMHzcQzSSFELEz8oDiQTOEw1k9QLUdx=bTxkEHg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Dave,

Windows batch has problem with file search and replace when it comes to
white spaces. Now the search and replace code is change to python.

So the installer creation issue is resolve.

Attached is the updated patch.

On Mon, Jun 6, 2016 at 2:51 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi,
>
> On Fri, Jun 3, 2016 at 9:30 PM, Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
> wrote:
>
>> Hello Dave.
>>
>> There was problem with the Make.bat file ^M characters which is been
>> removed.
>>
>> Issues are fixed along with some code and README tidied
>>
>
> I'm still seeing the same error:
>
> copy "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss.in"
> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
> 1 file(s) copied.
> Error on line 113 in
> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
> Semicolon (';') expected.
> Compile aborted.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--

Thanks & Regards

*Paresh More*

[image: NEW-EDB-logo-4c]

Pune, India.
Cell : +919922000564 | www.enterprisedb.com

Attachment Content-Type Size
pgadmin4_window_6_June_16.patch application/octet-stream 96.6 KB

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-06-06 17:20:52 pgAdmin 4 commit: Fixing the decryption issue during restoring the conn
Previous Message Susan Douglas 2016-06-06 15:31:01 Patch for pgAdmin docs