Re: PQconninfoParse()

2011/10/15 Dmitriy Igrishin <dmitigr(at)gmail(dot)com>

>
>
> 2011/10/15 Robert Haas <robertmhaas(at)gmail(dot)com>
>
>> On Mon, Oct 10, 2011 at 1:31 PM, Dmitriy Igrishin <dmitigr(at)gmail(dot)com>
>> wrote:
>> > Hey Robert,
>> >
>> > 2011/10/10 Robert Haas <robertmhaas(at)gmail(dot)com>
>> >>
>> >> On Tue, Sep 27, 2011 at 9:13 AM, Dmitriy Igrishin <dmitigr(at)gmail(dot)com>
>> >> wrote:
>> >> > First,
>> >> > "Returns parsed connection options from the provided connection
>> string."
>> >> > Its false. The returned array contains all options, rather than which
>> >> > only
>> >> > parsed from the provided connection string. This fact must be
>> specified
>> >> > in
>> >> > the documentation becase the name of the function mismatches its
>> >> > behaviour.
>> >>
>> >> What do you mean by "all" options? Where else are they coming from
>> >> besides the connection string?
>> >
>> > I mean options from
>> > static const PQconninfoOption PQconninfoOptions[]
>> > from interfaces/libpq/fe-connect.c
>>
>> Maybe we should change this:
>>
>> Note that only options explicitly specified in the string will have
>> values set in the result array; no defaults are inserted.
>>
>> To say something like this:
>>
>> All legal options will be present in the result array, but only those
>> explicitly specified in the string will have a corresponding value; no
>> defaults are inserted.
>>
> Exactly! Perfect!
>
Also, I would say something about deprecated options
such as "authtype" which are still presents in the returned
array.

>
>> --
>> Robert Haas
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> // Dmitriy.
>
>
>

--
// Dmitriy.