Re: Small patch to fix build on Windows

From: Dmitry Igrishin <dmitigr(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small patch to fix build on Windows
Date: 2019-08-08 19:46:07
Message-ID: CAAfz9KMKPqFEcxb3wdFJpEmEdcfr-OYZWuj6xm8udSw=Oy0B5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

чт, 8 авг. 2019 г. в 20:07, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
>
> On 2019-Aug-08, Dmitry Igrishin wrote:
>
> > my $prefixcmd =
> > - $solution->{options}->{python} . "\\python -c \"$pythonprog\"";
> > + "\"$solution->{options}->{python}\\python\" -c \"$pythonprog\"";
>
> I think you can make this prettier like this:
>
> my $prefixcmd = qq{"$solution->{options}->{python}\\python" -c "$pythonprog"};
This looks nice for a Perl hacker :-). As for me, it looks unusual and
a bit confusing. I never
programmed in Perl, but I was able to quickly understand where the
problem lies due to the
style adopted in other languages, when the contents are enclosed in
quotation marks, and
the quotation marks are escaped if they are part of the contents.
So, should I fix it? Any thoughts?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark G 2019-08-08 19:56:02 Re: Small const correctness patch
Previous Message Stephen Frost 2019-08-08 19:07:59 Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)