| From: | Dong Wook Lee <sh95119(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, "barwick(at)gmail(dot)com" <barwick(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_basebackup: add test about zstd compress option |
| Date: | 2022-12-06 12:53:13 |
| Message-ID: | CAAcByaJTcGM9X4k8G0G0-b3OSXqdUFskwciVtyGkC1Rad8MCyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> The only thing that I can think of would be if $decompress_program
> --test were failing, but actually trying to decompress succeeded. I
> would be inclined to dismiss that particular scenario as not important
> enough to be worth the additional CPU cycles.
When I wrote this test, it was just to increase coverage for pg_basebackup.
As I checked again, it already does that in the pg_verifybackup
008_untar.pl, 009_extrack.pl test you mentioned.
Therefore, I agree with your opinion.
---
Regards,
DongWook Lee.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2022-12-06 13:44:50 | Re: [PATCH] Check snapshot argument of index_beginscan and family |
| Previous Message | Takamichi Osumi (Fujitsu) | 2022-12-06 12:13:57 | RE: Time delayed LR (WAS Re: logical replication restrictions) |