| From: | James Coleman <jtc331(at)gmail(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Luc Vlaming <luc(at)swarm64(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: "could not find pathkey item to sort" for TPC-DS queries 94-96 |
| Date: | 2021-04-20 12:01:47 |
| Message-ID: | CAAaqYe9v3MPPHkWWy9H2uS7KgBHdseyONwGpcUjp6LRpc4Fvkw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 20, 2021 at 7:11 AM Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
>
> ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:
>
> > Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> >
> >> + /* We ignore binary-compatible relabeling on both ends */
> >> + while (expr && IsA(expr, RelabelType))
> >> + expr = ((RelabelType *) expr)->arg;
> >
> > There are 10 instances of this exact loop scattered around the codebase.
> > Is it worth it turning it into a static inline function?
>
> Something like the attached, maybe?
I'm not opposed to this, but I think it should go in a separate thread
since it's orthogonal to the bugfix there and also will confuse cfbot.
James
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-04-20 12:16:59 | Typo in dshash_find() comments |
| Previous Message | Patrik Novotny | 2021-04-20 11:59:44 | RFE: Make statistics robust for unplanned events |