| From: | James Coleman <jtc331(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se> |
| Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Date: | 2020-03-23 17:16:44 |
| Message-ID: | CAAaqYe9np1d9V+mL8Q7CGc=DdjwKz3L5nvDaQo5UHq0kYDHDTA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 23, 2020 at 1:05 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > ... all plan types that use only one child use the outer one. They
> > could use either, as long as it does that consistently, I think.
>
> Yeah, exactly. The outer/inner terminology is really only sensible
> for join nodes, but there isn't a third child-plan pointer reserved
> for single-child node types, so you gotta use one of those. And
> conventionally we use the "outer" one.
>
> regards, tom lane
Great, thanks for the explanation Alvaro and Tom; I'll fix that up in
my next patch series.
I idly wonder if a macro childPlanState() defined exactly the same as
outerPlanState() might _kinda_ make sense here, but I'm also content
to follow convention.
I might submit a small patch to the comment on those macros though to
expand on the explanation.
James
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-03-23 17:24:55 | Re: Assert() failures during RI checks |
| Previous Message | Tom Lane | 2020-03-23 17:05:19 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |