From: | James Coleman <jtc331(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Possible typo/unclear comment in joinpath.c |
Date: | 2021-04-14 15:36:38 |
Message-ID: | CAAaqYe8fxZjq3na+XkNx4C78gDqykH-7dbnzygm9Qa9nuDTePg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
In joinpath.c three times we reference "extra_lateral_rels" (with
underscores like it's a field), but as far as I can tell that's not a
field anywhere in the source code, and looking at the code that
follows it seems like it should be referencing "lateral_relids" (and
the "extra" is really "extra [in relation to relids]").
Assuming that interpretation is correct, I'd attached a patch to
change all three occurrences to "extra lateral_relids" to reduce
confusion.
Thanks,
James
Attachment | Content-Type | Size |
---|---|---|
v1-0001-Fix-extra_lateral_rels-typo.patch | application/octet-stream | 2.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Christensen | 2021-04-14 16:13:47 | [PATCH] expand the units that pg_size_pretty supports on output |
Previous Message | Tom Lane | 2021-04-14 14:49:37 | Re: Converting contrib SQL functions to new style |