| From: | James Coleman <jtc331(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Date: | 2020-03-15 02:55:23 |
| Message-ID: | CAAaqYe84ibSChm7ufMHcTdCmenbAOoS_fS18Z7ojSocHtrM6Sw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 13, 2020 at 1:06 PM James Coleman <jtc331(at)gmail(dot)com> wrote:
>
> On Thu, Mar 12, 2020 at 5:53 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> >
> > I gave this a very quick look; I don't claim to understand it or
> > anything, but I thought these trivial cleanups worthwhile. The only
> > non-cosmetic thing is changing order of arguments to the SOn_printf()
> > calls in 0008; I think they are contrary to what the comment says.
>
> Yes, I think you're correct (re: 0008).
>
> They all look generally good to me, and are included in the attached
> patch series.
I just realized something about this (unsure if in Alvaro's or in my
applying that) broke make check pretty decently (3 test files broken,
also much slower, and the incremental sort test returns a lot of
obviously broken results).
I'll take a look tomorrow and hopefully get a fix (probably will reply
to the more recent subthread's though).
James
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2020-03-15 06:26:07 | Re: truncating timestamps on arbitrary intervals |
| Previous Message | Tomas Vondra | 2020-03-15 02:23:12 | Re: Additional improvements to extended statistics |