Re: Correct docs re: rewriting indexes when table rewrite is skipped

On Thu, Mar 31, 2022 at 10:29 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Thu, Mar 31, 2022 at 10:14 AM James Coleman <jtc331(at)gmail(dot)com> wrote:
> > Is the attached more along the lines of what you were thinking?
>
> Yeah. Maybe this would be a little clearer: "For example, if the
> collation for a column has been changed, an index rebuild is always
> required, because the new sort order might be different. However, in
> the absence of a collation change, a column can be changed from text
> to varchar or vice versa without rebuilding the indexes, because these
> data types sort identically."

Updated.

> We don't seem to be very consistent about whether we write type names
> like VARCHAR in upper case or lower case in the documentation. I'd
> vote for using lower-case, but it probably doesn't matter much.

Grepping suggests lower case is more common (2 to 1) so I switched to
that. Interestingly for "text" it's 700+ to 1 :)

Thanks,
James Coleman