From: | Daniel Farina <daniel(at)heroku(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: SSL-mode error reporting in libpq |
Date: | 2011-08-23 01:04:19 |
Message-ID: | CAAZKuFZ8O5xs4nB8WYeBoQGziHbK2derhcCq5aPWyvG+bEFHVw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jul 24, 2011 at 11:48 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> We could perhaps go a bit further and make pqsecure_write responsible
> for the error message in non-SSL mode too, but it looks to me like
> pqSendSome has to have a switch on the errno anyway to decide whether to
> keep trying or not, so moving that responsibility would just lead to
> duplicative coding.
>
> Any objections?
No objection.
Some users we have have been confused by this message. At first I
thought it was an SSL renegotiation problem, but now I realize that
the message is a lie, so anything can be the problem. A better
message may well decrease support burden for us, and also help us find
problems...
--
fdr
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-08-23 03:23:30 | Re: 9.1rc1: TRAP: FailedAssertion("!(item_width > 0)", File: "costsize.c", Line: 3274) |
Previous Message | Robert Haas | 2011-08-22 23:22:47 | Re: cheaper snapshots redux |