| From: | Daniel Farina <daniel(at)heroku(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres_fdw vs data formatting GUCs (was Re: [v9.3] writable foreign tables) |
| Date: | 2013-03-20 06:28:26 |
| Message-ID: | CAAZKuFYtCZCQ+ROmigfdAyMxi682ZMrHyqA9cBsQrP-DRqKSaw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 19, 2013 at 10:37 PM, Daniel Farina <daniel(at)heroku(dot)com> wrote:
> I added programming around various NULL returns reading GUCs in this
> revision, v4.
Okay, one more of those fridge-logic bugs. Sorry for the noise. v5.
A missing PG_RETHROW to get the properly finally-esque semantics:
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -642,7 +642,10 @@ dblink_fetch(PG_FUNCTION_ARGS)
}
PG_CATCH();
{
+ /* Pop any set GUCs, if necessary */
restoreLocalGucs(&rgs);
+
+ PG_RE_THROW();
}
PG_END_TRY();
This was easy to add a regression test to exercise, and so I did (not
displayed here).
--
fdr
| Attachment | Content-Type | Size |
|---|---|---|
| dblink-guc-sensitive-types-v5.patch | application/octet-stream | 15.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2013-03-20 09:00:05 | Re: Ignore invalid indexes in pg_dump |
| Previous Message | David E. Wheeler | 2013-03-20 05:45:19 | Re: citext like searches using index |