| From: | Jacob Champion <jchampion(at)timescale(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Jelte Fennema <postgres(at)jeltef(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, thomas(at)habets(dot)se, pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert |
| Date: | 2023-01-11 19:06:45 |
| Message-ID: | CAAWbhmi5KEt3icdbXhSN8ALyWVK5cBuJeCOnng91HVc-X31ikQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 11, 2023 at 10:23 AM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Sorry to jump in (very) late in this game. So first, I like this general approach :)
Thanks!
> It feels icky to have to add configure tests just to make a test work. But I guess there isn't really a way around that if we want to test the full thing.
I agree...
> However, shouldn't we be using X509_get_default_cert_file_env() to get the name of the env? Granted it's unlikely to be anything else, but if it's an API you're supposed to use. (In an ideal world that function would not return anything in LibreSSL but I think it does include something, and then just ignores it?)
I think you're right, but before I do that, is the cure better than
the disease? It seems like that would further complicate a part of the
Perl tests that is already unnecessarily complicated. (The Postgres
code doesn't use the envvar at all.) Unless you already know of an
OpenSSL-alike that doesn't use that same envvar name?
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-01-11 19:18:42 | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode |
| Previous Message | Peter Geoghegan | 2023-01-11 19:06:26 | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode |