From: | Joel Jacobson <joel(at)trustly(dot)com> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Joachim Wieland <joe(at)mcknight(dot)de> |
Subject: | Re: Review for pg_dump: Sort overloaded functions in deterministic order |
Date: | 2012-10-10 21:07:34 |
Message-ID: | CAASwCXcHgEoM7CiOahL54GEMDpyuUU81nEOpXdCdn60_+UZ5VA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Joachim,
Attached, please find new patch. Test unchanged.
Best regards,
Joel
> Patch looks good, all concerns that had been raised previously have
> been addressed in this version of the patch.
>
> The only thing that IMO needs to change is a stylistic issue:
>
> if (fout->remoteVersion >= 80200)
> {
> [...]
> (fout->remoteVersion >= 80400) ?
> "pg_catalog.pg_get_function_identity_arguments(oid)" : "NULL::text",
> [...]
> }
>
> Please just create a whole new
>
> if (fout->remoteVersion >= 80400)
> {
> [...]
> }
>
> here.
>
> Other than that, the feature works as advertised and does not
> negatively affect runtime or memory consumption (the new field is only
> added to functions / aggregates).
>
> Please send a new version of the patch that changes the above
> mentioned item, the patch also needs rebasing (off by a couple of
> lines).
Attachment | Content-Type | Size |
---|---|---|
pg_dump_deterministic_order_v5.patch | application/octet-stream | 8.4 KB |
pg_dump_deterministic_order.t | application/x-troff | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2012-10-10 21:23:10 | Re: change in LOCK behavior |
Previous Message | Bruce Momjian | 2012-10-10 21:06:45 | Re: [GENERAL] pg_upgrade not detecting version properly |