Re: PL/Java new build plugin

On Thu, Jul 9, 2020, 7:44 PM Chapman Flack <chap(at)anastigmatix(dot)net> wrote:

> On 07/09/20 09:51, Kartik Ohri wrote:
>
> > Any suggestions what could be the problem? As far as I see in the
> > build.xml, I can only think of MSVC.RINT but it should not be probably
> the
> > cause.
>
> You could be on to something. I remember thinking that MSVC_RINT is
> probably no longer essential to the build, at least for MSVC > 2012
> or PG > 9.3. But still, if there's an MSVC-only define that uses it:
>
> https://github.com/amCap1712/pljava/blob/d6608ff/pljava-so/pom.xml#L120

I'll look further into this.

and it isn't being set to something, that might produce a null in the
> defines list.
>
> >> to squeeze a little more information out of a NullPointerException
> >> by putting the right -XX:... option in the MAVEN_OPTS environment
> >
> > Yes, I understand that but as you say it isn't beneficial in this case.
>
> I wonder if it wouldn't be worthwhile to have that in the MAVEN_OPTS
> for all the automated builds (with Java >= 14), just to save time if
> something else happens to blow up some day,
>
The latest preview builds of Java 15 come with this feature automatically
enabled. Probably, a consensus will be reached on the default state if this
feature before the General Availability later in the year. I don't know
what MAVEN_OPTS is but I'll learn about it and enable it in Java 14.

> Regards,
> -Chap
>