Re: PL/Java new build plugin

From: Kartik Ohri <kartikohri13(at)gmail(dot)com>
To: Chapman Flack <chap(at)anastigmatix(dot)net>
Cc: pljava-dev(at)lists(dot)postgresql(dot)org
Subject: Re: PL/Java new build plugin
Date: 2020-07-21 03:00:57
Message-ID: CAASLQ4MVCdq4j8oz4gEHue5XNurua=_PV0r7zFdM75L9bf3O=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pljava-dev

On Tue, Jul 21, 2020 at 8:29 AM Kartik Ohri <kartikohri13(at)gmail(dot)com> wrote:

> Something isn't quite right about the handling of -Dpljava.libjvmdefault;
>> the C compiler gives syntax errors if I use it (the build succeeds if
>> I don't). Running with -X shows this being passed to the compiler:
>>
>> -DPLJAVA_LIBJVMDEFAULT=${pljava.qlibjvmdefault}
>>
> It is because the plugin is no longer detecting PLJAVA_LIBJVMDEFAULT. I
> did not retain the method to automatically detect the variable and use it
> and set its value. Should we keep it in the configuration block in pom.xml
> since we have exposed the C quoting as well to the script engine or make an
> exception for this to be specified via command line ?
>
To be sure and also to confirm, I didn't misunderstand something, can you
share the configuration block and the maven command you executed ?

In response to

Responses

Browse pljava-dev by date

  From Date Subject
Next Message Chapman Flack 2020-07-21 03:25:17 Re: PL/Java new build plugin
Previous Message Kartik Ohri 2020-07-21 02:59:13 Re: PL/Java new build plugin