From: | Kartik Ohri <kartikohri13(at)gmail(dot)com> |
---|---|
To: | Chapman Flack <chap(at)anastigmatix(dot)net> |
Cc: | pljava-dev(at)lists(dot)postgresql(dot)org |
Subject: | Re: PL/Java new build plugin |
Date: | 2020-08-08 14:29:49 |
Message-ID: | CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pljava-dev |
On Sat, Aug 8, 2020 at 7:43 PM Chapman Flack <chap(at)anastigmatix(dot)net> wrote:
> On 08/08/20 10:00, Kartik Ohri wrote:
> > On Wed, Aug 5, 2020 at 9:09 AM Chapman Flack <chap(at)anastigmatix(dot)net>
> wrote:
> >
> >> On 08/04/20 08:07, Kartik Ohri wrote:
> >>
> >>> how it would work. I did try to go this route but I felt that it was
> >>> getting a bit difficult. So, after some thinking I moved the hard coded
> >>> values to the default values of the interface and utilised it in the
> >> mojo.
> >>> This approach worked well and I have pushed the changes. I have also
> >> pushed
> >>> a working example to test it. Please review it and let me know if
> changes
> >>> are required.
> >>
> >> I've created a branch
> >> https://github.com/jcflack/pljava/commits/invocable
> >> where you can see the way I had in mind for it to work.
> >>
> >> I took a look and this way seems to be really better than how I had done
> > it. Now that I look at it I feel if I had tried harder, I could have made
> > it work myself. I'll try harder next time. Thanks for helping with this.
> > I'll merge this into my branch and begin work on the nar maven part.
>
> Works out better than either person working alone. It's nice to have
> a collaborator. :)
>
> After you merge, would you mind creating a new branch name from that
> point, before continuing with the nar-maven part? I don't mind if it's
> a new name for the nar-maven part, or you keep 'plugin' for that part
> and use a new name to point to this reporting part.
>
>
I'll create a new branch for the nar stuff and begin working on that.
I think the reporting part will be just about ready for a pull request
> soon, so branching will allow us to do that while you continue with
> the nar stuff.
>
> I am still working on one more commit or so to get the relative links
> between javadoc for different modules working right. (Javadoc seems to
> have a misfeature that interferes; in the published docs on the site,
> I only got it working by using absolute URLs instead, to the actual
> tada.github.io site, but of course that makes them broken when testing
> in a local staging directory, and makes it harder to one day support
> publishing docs for > 1 PL/Java version. So I really want to solve
> the relative-link problem.)
>
> Regards,
> -Chap
From | Date | Subject | |
---|---|---|---|
Next Message | Chapman Flack | 2020-08-08 15:29:56 | the ReportScriptingMojo |
Previous Message | Chapman Flack | 2020-08-08 14:13:39 | Re: PL/Java new build plugin |