Re: heapgettup refactoring

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: heapgettup refactoring
Date: 2022-11-30 22:34:50
Message-ID: CAAKRu_bWPFT8ZX5pTw0nm_rpBrivSjB3wMntqnHNDwJAV1LdsA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 16, 2022 at 10:49 AM Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 04.11.22 16:51, Melanie Plageman wrote:
> > Thanks for the review!
> > Attached is v2 with feedback addressed.
>
> Your 0001 had already been pushed.
>
> I have pushed your 0002.
>
> I have also pushed the renaming of page -> block, dp -> page separately.
> This should reduce the size of your 0003 a bit.
>
> Please produce an updated version of the 0003 page for further review.

Thanks for looking at this!
I have attached a patchset with only the code changes contained in the
previous patch 0003. I have broken the refactoring down into many
smaller pieces for ease of review.

- Melanie

Attachment Content-Type Size
v3-0005-Add-heapgettup-helpers.patch text/x-patch 3.9 KB
v3-0002-Push-lpp-variable-closer-to-usage-in-heapgetpage.patch text/x-patch 2.3 KB
v3-0003-Add-heapgettup_initial_page-helper.patch text/x-patch 9.1 KB
v3-0001-Add-no-movement-scan-helper.patch text/x-patch 5.0 KB
v3-0004-Streamline-heapgettup-for-refactor.patch text/x-patch 8.5 KB
v3-0007-Refactor-heapgettup-and-heapgettup_pagemode.patch text/x-patch 9.8 KB
v3-0006-Add-heapgettup_advance_page.patch text/x-patch 6.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-11-30 22:35:01 Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas
Previous Message Greg Stark 2022-11-30 22:30:59 Re: Patch: Global Unique Index