| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BitmapHeapScan streaming read user and prelim refactoring |
| Date: | 2025-03-24 16:14:46 |
| Message-ID: | CAAKRu_bNfUHk4AjS665DMp-j=F05zeEDDZpxNbrvxO=eszMoSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 23, 2025 at 1:27 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> Perhaps it is better I just fix it since ripping out the skip fetch
> optimization has to be backported and even though that will look very
> different on master than on backbranches, I wonder if people will look
> for a "clean" commit on master which removes the feature.
This is the patch I intend to commit to fix this assuming my CI passes
and there are no objections. I did add a bit of coverage for this in
bitmapops.sql. I'm not sure if that is the right thing to do since
that coverage should be removed when we remove skip fetch and there is
no point in adding the extra query and vacuum freeze if we don't have
the skip fetch optimization.
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| Fix-bitmapheapscan-incorrect-recheck-of-NULL-tupl.patch | text/x-patch | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-03-24 16:16:40 | Re: dblink: Add SCRAM pass-through authentication |
| Previous Message | David G. Johnston | 2025-03-24 16:08:18 | Re: vacuum_truncate configuration parameter and isset_offset |