| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Calling PrepareTempTablespaces in BufFileCreateTemp |
| Date: | 2019-04-25 17:27:05 |
| Message-ID: | CAAKRu_b3V7XtBTUQcQozuC9Zmz1h+isFCjeLBR=WSsWJS7Ywpw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 25, 2019 at 9:19 AM Ashwin Agrawal <aagrawal(at)pivotal(dot)io> wrote:
> Just to provide my opinion, since we are at intersection and can go
> either way on this. Second approach (just adding assert) only helps
> if the code path for ALL future callers gets excersied and test exist for
> the
> same, to expose potential breakage. But with first approach fixes the issue
> for current and future users, plus excersicing the same just with a single
> test
> already tests it for future callers as well. So, that way first approach
> sounds
> more promising if we are fetch between the two.
>
> Would an existing test cover the code after moving PrepareTempTablespaces
into
OpenTemporaryFile?
--
Melanie Plageman
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-04-25 17:34:54 | Re: POC: Cleaning up orphaned files using undo logs |
| Previous Message | Tom Lane | 2019-04-25 16:45:03 | Re: Calling PrepareTempTablespaces in BufFileCreateTemp |