Re: Using read_stream in index vacuum

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Andrei Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Using read_stream in index vacuum
Date: 2024-10-21 21:05:17
Message-ID: CAAKRu_aROAeTx1Z-99UY1wE09NF_BYKG9BzK0ZoGCW+C1rU1tg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 21, 2024 at 4:49 PM Andrei Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
> 21.10.2024, 22:34, "Melanie Plageman" <melanieplageman(at)gmail(dot)com>:
>
> The whole point of the read stream callback provided by the caller is
> that the logic to get the next block should be there
>
> We must get number of blocks after examining last block. But callback returning EOF might be called before. With current API we have to restart.
>
> Removing extension lock will not change this.

I was suggesting you call RelationGetNumberOfBlocks() once
current_block == last_exclusive in the callback itself.

- Melanie

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul Jungwirth 2024-10-21 21:46:14 Re: SQL:2011 application time
Previous Message Andrei Borodin 2024-10-21 20:49:27 Re: Using read_stream in index vacuum